Conversation
The launcher reads the user's Windows locale, maps it to the POSIX name, and passes tryomarchy.locale= beside the zone and keyboard. Guest patch 0043 extends the host-locale service to generate that UTF-8 locale and set it as the system default when the value changes; integration revision and smoke test move to 11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guest ran en_US regardless of the Windows display language.
Launcher:
GetUserDefaultLocaleNamegives names such asde-DE; the launcher maps them to the POSIX form (de_DE, region required, script tags rejected) and passestryomarchy.locale=beside the zone and keyboard parameters.-localeoverrides it per launch (keepleaves the guest alone). Diagnostics record the host locale.Guest (patch 0043): the host-locale service validates the name, checks the locale source exists, enables the
xx_YY.UTF-8 UTF-8line in locale.gen, runs locale-gen, and writesLANGto locale.conf, only when the value changes so a language chosen inside the guest survives. Sessions pick it up at the next login. Tests cover generation, idempotence, and unsafe or unavailable names. Integration revision and smoke test move to 11.Tested in the VM: the launcher passed
tryomarchy.locale=en_US; the new script run inside the guest withde_DEgenerated the locale in 1.6 s, setLANG=de_DE.UTF-8, and reverted cleanly.